Move tests out of installable distribution#829
Move tests out of installable distribution#829maxrjones merged 2 commits intozarr-developers:mainfrom
Conversation
|
this is great, thank you! |
|
One note as a downstream packager: since they aren't in the package directory, it's totally fine if the tests are gone from the wheels now, but please if possible ensure that they stay in the sdist. |
how are the tests consumed downstream? |
thanks for keeping a watch on things! I manually verified that the sdist still includes the tests via |
|
FYI the failures are the same as on main, so I will merge despite not having 100% checks |
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (99.33%) is below the target coverage (100.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #829 +/- ##
=======================================
Coverage 99.33% 99.33%
=======================================
Files 26 26
Lines 898 898
=======================================
Hits 892 892
Misses 6 6 🚀 New features to boost your workflow:
|
We run all tests that are possible; that's how I find arch-specific or release candidate bugs.
Thanks for checking! Sorry I didn't have time to do so before. |
This PR moves the tests outside the source code directory, so that they are not included with the distributions. This was originally included as part of #826, but is really a distinct change which belongs as its own PR.
Closes #509
TODO: