When composed with multiscales, disallow spatial:transform at top level; require it on all layout items#15
Open
kylebarron wants to merge 5 commits intozarr-conventions:mainfrom
Conversation
kylebarron
changed the title
layout itemsmultiscales, disallow spatial:transform at top level; require it on all layout items
kylebarron
commented
Apr 7, 2026
Comment on lines
+225
to
+230
| "properties": { | ||
| "multiscales": { | ||
| "required": ["layout"] | ||
| } | ||
| }, | ||
| "required": ["multiscales"] |
Author
There was a problem hiding this comment.
We could change this to look for the specific multiscales uuid instead of the fields multiscales and layout, though above it hard-codes multiscales and layout as keys anyways
|
Just make transform and shape required everywhere. It doesn't hurt to be explicit, and it's tiny. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #12
Schema changes
multiscales.layoutexists, thenspatial:transformmust not exist at the top levelmultiscales.layoutexists, thenspatial:shapemust not exist at the top levelmultiscales.layoutexists, thenspatial:transformmust exist on all items withinlayoutChange list
sentinel2-tci.jsonis invalid because it doesn't have aspatial:transformon each item inlayout.dem-multiresolution.jsonis invalid because it has aspatial:transformat the top level.