Clarify authors. by vext01 · Pull Request #206 · ykjit/yk

vext01 · 2020-12-21T14:40:11Z

The main change is 3fbad79, then there's a commit to make the README overview better.

ykview/Cargo.toml

ltratt · 2020-12-21T17:48:34Z

README.md

+
+## Contributors
+
+Yorick is developed by the Software Development Team at King's College London,


I think we can be more inclusive here. Maybe something like "Yorick is developed by a team of people which can be seen in the ." I don't think we need a special mention.

Fixed in 12d05fc

ltratt · 2020-12-21T20:53:26Z

Please squash.

All Cargo manifests now list "The Yorick Developers" and we provide a link to the Github contributors page in the README.

vext01 · 2020-12-21T22:25:57Z

splat.

ltratt · 2020-12-21T22:57:40Z

bors r+

206: Clarify authors. r=ltratt a=vext01 Co-authored-by: Edd Barrett <vext01@gmail.com>

bors · 2020-12-21T22:58:14Z

Build failed:

buildbot/ykrustc-buildbot-build-script-hwt

vext01 · 2020-12-21T23:05:29Z

bors try

bors · 2020-12-21T23:05:47Z

try

Build failed:

buildbot/ykrustc-buildbot-build-script-hwt

ltratt · 2020-12-22T09:36:10Z

cargo not being found is a bit odd! Let's try again.

bors r+

206: Clarify authors. r=ltratt a=vext01 Co-authored-by: Edd Barrett <vext01@gmail.com>

bors · 2020-12-22T09:36:55Z

Build failed:

buildbot/ykrustc-buildbot-build-script-hwt

vext01 · 2020-12-22T10:14:36Z

I wonder if the upstream sync broke it. Maybe cargo is installed in a different location or something. I'll look into it when I find a moment.

…

On Tue, 22 Dec 2020, 09:36 Laurence Tratt, ***@***.***> wrote: cargo not being found is a bit odd! Let's try again. bors r+ — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#206 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAETWGYLMFGER6MKVYETMTLSWBSBTANCNFSM4VEJWGHA> .

vext01 · 2020-12-23T14:42:37Z

Made a little progress with this. Something seems to have changed with x.py install such that the directory we tar up for the CI snapshot is bogus, and only contains:

$ find build/ykrustc-stage2-latest/
build/ykrustc-stage2-latest/
build/ykrustc-stage2-latest/libexec
build/ykrustc-stage2-latest/libexec/cargo-credential-1password
build/ykrustc-stage2-latest/VERSION

I also notice something wrong with the CI snapshot directory:

-rwxrwxr-x  1 buildbot-worker1 buildbot-workers 124643091 Dec 15 17:18 ykrustc-hw-stage2-1b4b37bf.tar.bz2
-rwxrwxr-x  1 buildbot-worker3 buildbot-workers 124650393 Dec 15 17:26 ykrustc-hw-stage2-5ccb675d.tar.bz2
-rwxrwxr-x  1 buildbot-worker4 buildbot-workers 124634002 Dec 15 17:23 ykrustc-hw-stage2-60d5035b.tar.bz2
-rwxrwxr-x  1 buildbot-worker4 buildbot-workers    298379 Dec 21 13:48 ykrustc-hw-stage2-92cb5763.tar.bz2
-rwxrwxr-x  1 buildbot-worker1 buildbot-workers 124638644 Dec 21 13:10 ykrustc-hw-stage2-b7178dda.tar.bz2
-rwxrwxr-x  1 buildbot-worker2 buildbot-workers 124786567 Dec 17 14:59 ykrustc-hw-stage2-ec7fe7f5.tar.bz2
lrwxrwxrwx  1 buildbot-worker4 buildbot-workers        61 Dec 21 13:48 ykrustc-hw-stage2-latest.tar.bz2 -> /opt/ykrustc-bin-snapshots/ykrustc-hw-stage2-92cb5763.tar.bz2
-rwxrwxr-x  1 buildbot-worker2 buildbot-workers 124668885 Dec 16 07:21 ykrustc--stage2-5ccb675d.tar.bz2
-rwxrwxr-x  1 buildbot-worker3 buildbot-workers    298217 Dec 23 07:21 ykrustc--stage2-92cb5763.tar.bz2
lrwxrwxrwx  1 buildbot-worker3 buildbot-workers        59 Dec 23 07:21 ykrustc--stage2-latest.tar.bz2 -> /opt/ykrustc-bin-snapshots/ykrustc--stage2-92cb5763.tar.bz2

My guess there is that the removal of STD_TRACER_MODE wasn't done quite right.

Out of time for now :)

ltratt · 2020-12-23T14:43:09Z

Aha, OK!

vext01 · 2020-12-30T19:09:58Z

I've been slowly investigating this. It seems the installer is currently in flux, and this is likely the source of our problems: https://rust-lang.zulipchat.com/#narrow/stream/182449-t-compiler.2Fhelp/topic/.60x.2Epy.20install.60.20broken.3F

ltratt · 2020-12-30T19:11:04Z

It looks like there's a PR fix up now? rust-lang/rust#80514

vext01 · 2020-12-30T21:52:40Z

Once that's merged, I'll sync upstream and hopefully it will fix our issues. We actually saw a different problem, but I'm hoping it's related. I'm also going to add CI steps that check that certain binaries exist in the install dir, like cargo and rustc. Then we can catch this kind of thing earlier next time.

…

On Wed, 30 Dec 2020, 19:11 Laurence Tratt, ***@***.***> wrote: It looks like there's a PR fix up now? rust-lang/rust#80514 <rust-lang/rust#80514> — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#206 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAETWG7MNCOIGIQJKIHHJV3SXN3NLANCNFSM4VEJWGHA> .

ltratt · 2021-01-01T08:34:46Z

I've checked and rust-lang/rust#80514 has been merged into rust's master branch, even though the PR is still open. So I think we're good to go!

vext01 · 2021-01-01T18:29:22Z

Using this morning's upstream master, x.py install no longer fails, but it doesn't actually put anything in the install dir.

ltratt · 2021-01-01T19:18:11Z

Ye gods :/

vext01 · 2021-01-05T15:42:25Z

bors try

bors · 2021-01-05T15:45:41Z

try

Build succeeded:

buildbot/ykrustc-buildbot-build-script-hwt

vext01 · 2021-01-05T15:46:33Z

@ltratt this is good to go.

ltratt · 2021-01-05T15:48:33Z

Do you want/need to rebase against master?

vext01 · 2021-01-05T15:50:38Z

It's already up to date, so we can go ahead.

ltratt · 2021-01-05T15:57:36Z

bors r+

bors · 2021-01-05T16:00:56Z

Build succeeded:

buildbot/ykrustc-buildbot-build-script-hwt

vext01 assigned ltratt Dec 21, 2020

bjorn3 reviewed Dec 21, 2020

View reviewed changes

ykview/Cargo.toml Outdated Show resolved Hide resolved

ltratt reviewed Dec 21, 2020

View reviewed changes

bjorn3 approved these changes Dec 21, 2020

View reviewed changes

vext01 added 2 commits December 21, 2020 22:25

Move to our new contributors scheme.

804412c

All Cargo manifests now list "The Yorick Developers" and we provide a link to the Github contributors page in the README.

Update general overview in the README.md.

466fa50

vext01 force-pushed the authors branch from 12d05fc to 466fa50 Compare December 21, 2020 22:25

bors bot added a commit that referenced this pull request Dec 21, 2020

Merge #206

01f9eb4

206: Clarify authors. r=ltratt a=vext01 Co-authored-by: Edd Barrett <vext01@gmail.com>

bors bot added a commit that referenced this pull request Dec 21, 2020

Try #206:

e18bb4c

bors bot added a commit that referenced this pull request Dec 22, 2020

Merge #206

7e83381

206: Clarify authors. r=ltratt a=vext01 Co-authored-by: Edd Barrett <vext01@gmail.com>

vext01 mentioned this pull request Jan 5, 2021

Temporary fix for CI softdevteam/ykrustc#163

Merged

bors bot added a commit that referenced this pull request Jan 5, 2021

Try #206:

ee96649

bors bot merged commit 89ffa9f into ykjit:master Jan 5, 2021

vext01 deleted the authors branch January 5, 2021 16:04


		## Contributors

		Yorick is developed by the Software Development Team at King's College London,

Conversation

vext01 commented Dec 21, 2020

Uh oh!

Uh oh!

ltratt Dec 21, 2020

Choose a reason for hiding this comment

Uh oh!

vext01 Dec 21, 2020

Choose a reason for hiding this comment

Uh oh!

ltratt commented Dec 21, 2020

Uh oh!

vext01 commented Dec 21, 2020

Uh oh!

ltratt commented Dec 21, 2020

Uh oh!

bors bot commented Dec 21, 2020

Uh oh!

vext01 commented Dec 21, 2020

Uh oh!

bors bot commented Dec 21, 2020

try

Uh oh!

ltratt commented Dec 22, 2020

Uh oh!

bors bot commented Dec 22, 2020

Uh oh!

vext01 commented Dec 22, 2020 via email

Uh oh!

vext01 commented Dec 23, 2020

Uh oh!

ltratt commented Dec 23, 2020

Uh oh!

vext01 commented Dec 30, 2020

Uh oh!

ltratt commented Dec 30, 2020

Uh oh!

vext01 commented Dec 30, 2020 via email

Uh oh!

ltratt commented Jan 1, 2021

Uh oh!

vext01 commented Jan 1, 2021

Uh oh!

ltratt commented Jan 1, 2021

Uh oh!

vext01 commented Jan 5, 2021

Uh oh!

bors bot commented Jan 5, 2021

try

Uh oh!

vext01 commented Jan 5, 2021

Uh oh!

ltratt commented Jan 5, 2021

Uh oh!

vext01 commented Jan 5, 2021

Uh oh!

ltratt commented Jan 5, 2021

Uh oh!

bors bot commented Jan 5, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants