Skip to content

fix: handle precondition-failed error type in document PUT/POST responses #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chomatdam wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: handle precondition-failed error type in document PUT/POST responses #106

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 16 additions & 5 deletions src/main/com/yetanalytics/lrs/pedestal/routes/documents.cljc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,11 @@
(defn put-response
[ctx {:keys [error]}]
(if error
(assoc ctx :io.pedestal.interceptor.chain/error error)
(let [exd (ex-data error)]
(if (#{:com.yetanalytics.lrs.xapi.document/precondition-failed}
(:type exd))
(assoc ctx :response {:status 412})
(assoc ctx :io.pedestal.interceptor.chain/error error)))
(assoc ctx :response {:status 204})))


Expand Down Expand Up @@ -375,11 +379,18 @@
[ctx {:keys [error] :as _lrs-response}]
(if error
(let [exd (ex-data error)]
(if (#{:com.yetanalytics.lrs.xapi.document/json-read-error
:com.yetanalytics.lrs.xapi.document/json-not-object-error
:com.yetanalytics.lrs.xapi.document/invalid-merge}
(:type exd))
(cond
(#{:com.yetanalytics.lrs.xapi.document/precondition-failed}
(:type exd))
(assoc ctx :response {:status 412})

(#{:com.yetanalytics.lrs.xapi.document/json-read-error
:com.yetanalytics.lrs.xapi.document/json-not-object-error
:com.yetanalytics.lrs.xapi.document/invalid-merge}
(:type exd))
(assoc ctx :response {:status 400})

:else
(assoc ctx :io.pedestal.interceptor.chain/error error)))
(assoc ctx :response {:status 204})))

Expand Down