Fix migrate() bug and clarify ExtendRef requirements in documentation#10
Draft
Copilot wants to merge 2 commits intomigrate-protocolfrom
Draft
Fix migrate() bug and clarify ExtendRef requirements in documentation#10Copilot wants to merge 2 commits intomigrate-protocolfrom
Copilot wants to merge 2 commits intomigrate-protocolfrom
Conversation
Co-authored-by: yeap-oneke <213803782+yeap-oneke@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add capability migration functionality for protocol objects
Fix migrate() bug and clarify ExtendRef requirements in documentation
Nov 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses review feedback from PR #9 identifying a bug in
migrate()functions and unclear documentation about ExtendRef requirements.Bug Fix
object_signercall inside existence check: Previously called before checking ifCapability<OldProtocol, R>exists, causing abort even when migrating capabilities that don't exist, breaking the intended silent no-op behavior.Documentation Improvements
migrate()functions: Clarify thatExtendRefunderOldProtocolis required for all migrations, not just when migratingExtendRefitselfmigrate_all()functions: Document that capabilities must be in storage (not extracted) and missing capabilities are silently skippedExtendRefmust be migrated last inmigrate_all()Applied to both
protocol_objectandprotocol_fungible_assetmodules.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.