Skip to content

Add Option add-in to customize frames#2

Merged
yarlson merged 3 commits intoyarlson:mainfrom
klausman:frames
Feb 13, 2025
Merged

Add Option add-in to customize frames#2
yarlson merged 3 commits intoyarlson:mainfrom
klausman:frames

Conversation

@klausman
Copy link
Copy Markdown
Contributor

Can be used like so:

      p := pin.New("Processing...",
          pin.WithSpinnerFrames([]rune{'.', 'o', 'O', '0', 'O', 'o'}),
      )

Can be used like so:

```
      p := pin.New("Processing...",
          pin.WithSpinnerFrames([]rune{'.', 'o', 'O', '0', 'O', 'o'}),
      )
```
Repository owner deleted a comment from codecov bot Feb 13, 2025
@yarlson
Copy link
Copy Markdown
Owner

yarlson commented Feb 13, 2025

Could you please update tests as well?

@klausman
Copy link
Copy Markdown
Contributor Author

Could you please update tests as well?

I am not sure how to properly test setting the spinner frames, since they never show up when used non-interactive. And when used interactive, the output is not captured. I could of course make something similar to the Basic Usage test, but with custom frames, to see if the call works at all. The added code doesn't have any error paths, so there's nothing to test there, either.

@yarlson
Copy link
Copy Markdown
Owner

yarlson commented Feb 13, 2025

Could you please update tests as well?

I am not sure how to properly test setting the spinner frames, since they never show up when used non-interactive. And when used interactive, the output is not captured. I could of course make something similar to the Basic Usage test, but with custom frames, to see if the call works at all. The added code doesn't have any error paths, so there's nothing to test there, either.

Similar to the Basic Usage test would be good for now.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 13, 2025

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@yarlson yarlson merged commit 5249dae into yarlson:main Feb 13, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants