Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors how list styling is applied across the Sage theme by scoping “styled lists” to Gutenberg list blocks, and removing now-unnecessary list reset classes from navigation and UI lists.
Changes:
- Scope list spacing/indent/marker styles to
.wp-block-list(instead of allul/ol) and introduce shareduse-block-spacingutility. - Remove
list-none/padding/margin reset classes from menu markup and related component CSS where global list styling previously forced overrides. - Simplify editor block style registration (buttons only) and drop the custom
core/list“unstyled” block style registration.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| web/app/themes/sage/resources/views/sections/footer.blade.php | Removes list reset classes from footer nav menu markup. |
| web/app/themes/sage/resources/views/components/meta/list.blade.php | Removes list reset classes from the meta list component. |
| web/app/themes/sage/resources/views/components/layout/index.blade.php | Removes breadcrumb list reset classes; adjusts formatting/indentation. |
| web/app/themes/sage/resources/views/components/header/top-bar.blade.php | Removes list reset classes from top-bar menu markup; formatting change. |
| web/app/themes/sage/resources/views/components/header/navigation.blade.php | Removes list reset classes from primary nav menu markup. |
| web/app/themes/sage/resources/views/components/header/mobile-menu.blade.php | Removes list reset classes from mobile menu markup. |
| web/app/themes/sage/resources/styles/elements/lists.css | Replaces global ul/ol styling with .wp-block-list-scoped styling using CSS variables. |
| web/app/themes/sage/resources/styles/components/nav.css | Removes list reset utilities from .sub-menu styling. |
| web/app/themes/sage/resources/styles/components/mobile-menu.css | Removes list reset utilities from mobile submenu styling. |
| web/app/themes/sage/resources/styles/blocks/timeline/shared.css | Removes list-none from timeline collapse summary styling. |
| web/app/themes/sage/resources/styles/base/utilities.css | Adds @utility use-block-spacing for consistent block spacing behavior. |
| web/app/themes/sage/resources/scripts/editor/block-styles.js | Registers button block styles via forEach; removes list block style registration. |
Comments suppressed due to low confidence (1)
web/app/themes/sage/resources/styles/blocks/timeline/shared.css:58
- Removing
list-nonefrom thesummaryelement can reintroduce the default disclosure marker in non-WebKit browsers (e.g., Firefox). Currently only::-webkit-details-markeris hidden, so consider restoringlist-style: none(or hiding::marker) to keep the marker consistently hidden across browsers.
.wp-block-yard-timeline-item-collapse__summary {
@apply relative min-h-8 cursor-pointer pr-10;
&::-webkit-details-marker {
@apply hidden;
}
YvetteNikolov
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tailwind Preflight reset lijsten standaard, dus geen markers, margin en padding. Onze list styling wordt toegepast op alle lijsten, waardoor we het werk van de reset ongedaan maken en op veel plekken
list-none,m-0enpl-0classes gebruiken om de lijst styling nogmaals ongedaan te maken.Deze PR scoped de échte lijst styling binnen de
.wp-block-listclass en verwijdert alle handmatige resets op andere plekken in de code.In sommige gevallen komen lijsten die wel markers moeten hebben niet uit het Gutenberg block, bijvoorbeeld omdat content uit een ander CMS is geïmporteerd. In dat soort gevallen zou de selecter uitgebreid kunnen worden o.b.v. een specifieke class, bijvoorbeeld
.wysiwyg-content :is(ol, ul).