-
Notifications
You must be signed in to change notification settings - Fork 0
feat: use Navi for primary navigation #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
WybeBosch
wants to merge
20
commits into
main
Choose a base branch
from
feat/add-navi-for-navigation-menu
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
36a6c24
feat: use Navi for primary navigation
WybeBosch df0fe0a
feat: update primary navigation initialization
Yannicvanveen c033729
feat: replace arbitrary group classes
Yannicvanveen 9744c47
feat: clearer group name / replace padding with gap / move list reset…
Yannicvanveen e9d3670
feat: implement Navi in footer
Yannicvanveen 4fdec3a
feat: implement Navi in top bar
Yannicvanveen 83c2999
feat: remove top-bar.css
Yannicvanveen 8f3184b
fix: use correct values and selectors for updating --top-bar-height
Yannicvanveen fb2733d
feat: add NaviComposer
Yannicvanveen cb1b91d
feat: implement Navi top bar navigation in mobile menu
Yannicvanveen ee76f80
feat: implement Navi primary navigation in mobile menu
Yannicvanveen c758ddb
fix: aria-current conditions
Yannicvanveen efc8922
feat: use gap for primary nav list
Yannicvanveen e678b13
chore: regenerate lockfile after rebase
YvetteNikolov b947ea5
refactor: move mobile-menu.css into blade template
YvetteNikolov 7ba1b0b
style: small styling changes
YvetteNikolov 749af8a
fix: add ->classes to all navigation items
YvetteNikolov c128bcc
refactor: text-primary-* to text-primary
YvetteNikolov 207f956
feat: first step of integrating the components and optimized frontend js
YvetteNikolov cbd2c25
feat: refactor to using item only on link, and using data-mode attribute
YvetteNikolov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,10 @@ | ||
| # Hoist these packages to the node_modules root for formatting and linting | ||
| overrides: | ||
| '@yardinternet/brave-frontend-kit': link:../../../../Packages/brave-frontend-kit | ||
|
|
||
| publicHoistPattern: | ||
| - prettier | ||
| - stylelint | ||
| - eslint | ||
| - stylelint-config-recommended | ||
| - stylelint-config-idiomatic-order | ||
| - '@babel/preset-react' | ||
| - prettier | ||
| - stylelint | ||
| - eslint | ||
| - stylelint-config-recommended | ||
| - stylelint-config-idiomatic-order | ||
| - '@babel/preset-react' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace App\View\Composers; | ||
|
|
||
| use Log1x\Navi\Navi; | ||
| use Roots\Acorn\View\Composer; | ||
|
|
||
| class NaviComposer extends Composer | ||
| { | ||
| /** | ||
| * List of views served by this composer. | ||
| * | ||
| * @var array | ||
| */ | ||
| protected static $views = [ | ||
| 'components.header.*', | ||
| 'sections.footer', | ||
| ]; | ||
|
|
||
| /** | ||
| * Data to be passed to view before rendering, but after merging. | ||
| */ | ||
| public function override(): array | ||
| { | ||
| return [ | ||
| 'footerNavigation' => $this->footerNavigation(), | ||
| 'primaryNavigation' => $this->primaryNavigation(), | ||
| 'topBarNavigation' => $this->topBarNavigation(), | ||
| ]; | ||
| } | ||
|
|
||
| public function footerNavigation(): Navi | ||
| { | ||
| return Navi::make()->build('footer_navigation'); | ||
| } | ||
|
|
||
| public function primaryNavigation(): Navi | ||
| { | ||
| return Navi::make()->build('primary_navigation'); | ||
| } | ||
|
|
||
| public function topBarNavigation(): Navi | ||
| { | ||
| return Navi::make()->build('top_bar_navigation'); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -193,3 +193,7 @@ | |
| minmax( min( 100%, var( --min, 30ch ) ), 1fr ) | ||
| ); | ||
| } | ||
|
|
||
| @utility list-reset { | ||
| @apply mb-0 list-none pl-0; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
53 changes: 0 additions & 53 deletions
53
web/app/themes/sage/resources/styles/components/mobile-menu.css
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note voor mijzelf, dat de changes hiervan natuurlijk in een branch zitten in brave-frontend-kit. Vandaar dat ik het niet kon vinden toen ik global search deed.
https://github.com/yardinternet/brave-frontend-kit/tree/feat/brave-nav