v9: Migrate to GNOME 45-50, ES modules, libadwaita prefs#13
Open
dudkitt wants to merge 1 commit intoxynium:mainfrom
Open
v9: Migrate to GNOME 45-50, ES modules, libadwaita prefs#13dudkitt wants to merge 1 commit intoxynium:mainfrom
dudkitt wants to merge 1 commit intoxynium:mainfrom
Conversation
Extension (extension.js): - Rewrite to ES modules with Extension base class - Replace imports.gi/ui with gi:// and resource:// imports - Move all state from globals into WebFeedIndicator instance - Replace log() with console.log(), add_actor() with add_child() - Replace Util.trySpawnCommandLine with Gio.AppInfo.launch() - Use MessageTray.Source for persistent GNOME notifications - Add HTML entity decoder for feed titles (named, numeric, hex) - Fallback to newest item date when feed-level date is missing - Sort feed items by publish date (newest first) - Fix closure bug in menu item click handlers Preferences (prefs.js): - Rewrite to ExtensionPreferences class with fillPreferencesWindow() - Replace GTK3 TreeView/ListStore/Dialog with Adw widgets - Use Gtk.ListBox for dynamic feed list (Adw.PreferencesGroup.remove() broken) - Use Adw.MessageDialog for add/edit with proper destroy() lifecycle - Set activatable: false on ActionRows to fix button click propagation Metadata: - shell-version: 45-50, add settings-schema field - Version bump to 9 Locales: - Update pot template and existing fr/nl translations - Add ru, uk, pl, zh_CN, es, pt_BR translations - Fix nl .mo filename (nl.mo → webfeed.mo)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Complete rewrite of the WebFeed extension to support GNOME Shell 45–50 using the modern ES modules API. The legacy
imports.*system is fully replaced. Preferences UI migrated from GTK3 to GTK4/libadwaita. Added 6 new translations.Breaking changes
prefs.uiis no longer used (preferences built programmatically with Adw widgets)Extension (extension.js)
gi://,resource:///, andlocal .jsfilesExtensionbase class withenable()/disable()instead of standalone functionssettings,feedsArray,rxAsync,secu) moved intoWebFeedIndicatorinstancelog()→console.log(),add_actor()→add_child(),substr() → substring()Util.trySpawnCommandLine()→Gio.AppInfo.create_from_commandline().launch()ExtensionUtils.openPrefs()→Extension.openPreferences()Preferences (prefs.js)
ExtensionPreferencesbase class withfillPreferencesWindow()GTK3 TreeView/ListStore/Dialog→Adw PreferencesPage/PreferencesGroup/ActionRow/MessageDialogGtk.ListBoxfor dynamic feed list (Adw.PreferencesGroup.remove() does not work for dynamic rows)Adw.MessageDialogwith properdestroy()lifecycle (text saved before destroy to prevent data loss)activatable: false on feed rows to fix button click propagation
Metadata (metadata.json)
getSettings()without explicit schema ID)Locales
Files changed
File Change
extension.js Full rewrite
prefs.js Full rewrite
metadata.json Updated
jsxml.js Added export
rss.js var class → export class
atom.js var class → export class
locale/webfeed.pot Updated
locale/fr.po, locale/nl.po Updated
locale/ru.po New
locale/uk.po New
locale/pl.po New
locale/zh_CN.po New
locale/es.po New
locale/pt_BR.po New
All LC_MESSAGES/webfeed.mo Recompiled
Testing
Tested on GNOME Shell 49.4 (Fedora). RSS and Atom feeds load, parse, display and open in browser correctly. Preferences window opens, all settings bind properly, feed list CRUD operations work.
Tools
Developed with VS Codium + Continue extension. AI assistant: Claude (Anthropic) — code migration, libadwaita prefs rewrite, HTML decoder, translations, PR description.