fix: AppImage CI deps — add patchelf, drop unused appindicator#12
Merged
Conversation
Add patchelf so linuxdeploy's GTK plugin can rewrite RPATHs in bundled libraries. Without it, the AppImage loads system libs at runtime instead of its own, causing ABI crashes on distros other than the build host (e.g. Fedora when built on Ubuntu). Remove libayatana-appindicator3-dev — the project doesn't use tray/ appindicator features (no tray-icon in Cargo.toml tauri features). Supersedes #11. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
patchelfto CI Linux deps — linuxdeploy's GTK plugin uses it to rewrite RPATHs in bundled libraries so the AppImage loads its own libs instead of the host system's. Without this, the AppImage crashes on distros with different library ABIs than the build host (e.g. Fedora when built on Ubuntu 22.04).libayatana-appindicator3-dev— the project doesn't enable Tauri'stray-iconfeature, so this dependency is unused.Context
Supersedes #11, which correctly identified the AppImage issue but:
libgtk-3-dev,libssl-dev) that would break the CI buildlibayatana-appindicator3-devfor the deprecatedlibappindicator3-devThis PR makes the minimal correct fix — just add
patchelfand drop the unused dep.Test plan
🤖 Generated with Claude Code