Rework config file generation and fix cases where configs were ignored#183
Open
itsschwer wants to merge 4 commits intoxoxfaby:masterfrom
Open
Rework config file generation and fix cases where configs were ignored#183itsschwer wants to merge 4 commits intoxoxfaby:masterfrom
itsschwer wants to merge 4 commits intoxoxfaby:masterfrom
Conversation
Avoid cluttering users' config folder
To further improve consistency with other components, hooking functions should be moved from the constructor to the currently empty `StatsDisplay.Hook()`
Sorting logic should probably be moved to ItemSorting.cs
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
StatsDisplayEnableand replace withComponentsStatsDisplay(previously effectively useless)StatsDisplaycomponent more consistent with other components — see below for further suggestionsComponentsItemSortingis enabled before attempting to sort Command/Scrapper menusPotential future changes
I wasn't sure if I should work on these areas, if you had existing plans or suggestions, or if I should open these as issues.
StatsDisplay.Hook()is empty and inconsistent with other components (hooking currently occurs in constructor?)CommandImprovementsandItemSortingCommandImprovements.cstoItemSorting.cs, using anotherPickupPickerPanel_SetPickupOptionshookNotificiations→NotificationsEquipement→Equipment