Open
Conversation
added 7 commits
June 6, 2024 15:24
added 5 commits
June 7, 2024 11:57
…el-tests # Conflicts: # python/pyxet/scripts/run_tests.sh
Author
|
Edit: Real issue here is the fact that xet blob is not multiprocess safe. That must be fixed before this can be parallelized. |
Contributor
Oh! which part is not? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main issue is that git xet clone with a single mdbv1 is not process safe -- two tests trying to read from a remote mdbv1 repo will cause a crash. This fixes that specific issue by merging the mdbv1 tests into a single test that would not be run in parallel.
The result is a significant speedup when running pyxet tests.