Skip to content

Row limit on get list items #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
julienxaop wants to merge 5 commits into
base: update-to-savon-1.0
Choose a base branch
from
+7 −4
Open

Row limit on get list items #3

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6acb4d0
Add row_limit option to GetListItems and GetListChangesSinceToken que…
Mar 6, 2012
e9e2601
Don't use 'try' method which come from rails. Sorry.
Mar 6, 2012
8b59ded
:row_limit => nil give errors when the token is present. (Apparenty n…
Mar 6, 2012
144e355
row_limit instead of 'ro w_limit' (stange that I didn't catch this …
Apr 11, 2012
2a43192
RowLimit Bux fixed.
Nov 19, 2012
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions lib/activesp/list.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,7 @@ def create_folder!(parameters = {})
def changes_since_token(token, options = {})
options = options.dup
no_preload = options.delete(:no_preload)
row_limit = (r_l = options.delete(:row_limit)) ? {'rowLimit' => r_l.to_s} : {}
options.empty? or raise ArgumentError, "unknown options #{options.keys.map { |k| k.inspect }.join(", ")}"

if no_preload
Expand All @@ -213,9 +214,9 @@ def changes_since_token(token, options = {})
view_fields = Builder::XmlMarkup.new.ViewFields
end
if token
result = call("Lists", "GetListItemChangesSinceToken", "listName" => @id, 'queryOptions' => '<queryOptions xmlns:s="http://schemas.microsoft.com/sharepoint/soap/" ><QueryOptions/></queryOptions>', 'changeToken' => token, 'viewFields' => view_fields)
result = call("Lists", "GetListItemChangesSinceToken", {"listName" => @id, 'queryOptions' => '<queryOptions xmlns:s="http://schemas.microsoft.com/sharepoint/soap/" ><QueryOptions/></queryOptions>', 'changeToken' => token, 'viewFields' => view_fields}.merge(row_limit))
else
result = call("Lists", "GetListItemChangesSinceToken", "listName" => @id, 'queryOptions' => '<queryOptions xmlns:s="http://schemas.microsoft.com/sharepoint/soap/" ><QueryOptions/></queryOptions>', 'viewFields' => view_fields)
result = call("Lists", "GetListItemChangesSinceToken", {"listName" => @id, 'queryOptions' => '<queryOptions xmlns:s="http://schemas.microsoft.com/sharepoint/soap/" ><QueryOptions/></queryOptions>', 'viewFields' => view_fields}.merge(row_limit))
end
updates = []
result.xpath("//z:row", NS).each do |row|
Expand Down Expand Up @@ -506,8 +507,10 @@ def permissions
end
cache :permissions, :dup => :always

def get_list_items(view_fields, query_options, query)
result = call("Lists", "GetListItems", { "listName" => @id, "viewFields" => view_fields, "queryOptions" => query_options }.merge(query))
def get_list_items(view_fields, query_options, query, options = {})
options = options.dup
row_limit = (r_l = options.delete(:row_limit)) ? {'rowLimit' => r_l.to_s} : {}
result = call("Lists", "GetListItems", {"listName" => @id, "viewFields" => view_fields, "queryOptions" => query_options}.merge(query).merge(row_limit))
result.xpath("//z:row", NS).each do |row|
yield clean_item_attributes(row.attributes)
end
Expand Down