Add Alternative LC3 Executor and I/O Implementations#10
Draft
Bennett-Petzold wants to merge 9 commits intomainfrom
Draft
Add Alternative LC3 Executor and I/O Implementations#10Bennett-Petzold wants to merge 9 commits intomainfrom
Bennett-Petzold wants to merge 9 commits intomainfrom
Conversation
The `pinned_init` crate is needed to actually initialize the large internal array on heap, instead of filling up memory.
Bennett-Petzold
temporarily deployed
to
testing
GitHub Actions
Inactive
Bennett-Petzold
had a problem deploying
to
testing
GitHub Actions
Failure
Bennett-Petzold
had a problem deploying
to
testing
GitHub Actions
Failure
Bennett-Petzold
had a problem deploying
to
testing
GitHub Actions
Failure
Bennett-Petzold
had a problem deploying
to
testing
GitHub Actions
Failure
Bennett-Petzold
had a problem deploying
to
testing
GitHub Actions
Error
Bennett-Petzold
had a problem deploying
to
testing
GitHub Actions
Error
Bennett-Petzold
had a problem deploying
to
testing
GitHub Actions
Failure
Bennett-Petzold
temporarily deployed
to
testing
GitHub Actions
Inactive
Bennett-Petzold
had a problem deploying
to
testing
GitHub Actions
Failure
Bennett-Petzold
had a problem deploying
to
testing
GitHub Actions
Failure
Bennett-Petzold
had a problem deploying
to
testing
GitHub Actions
Failure
Bennett-Petzold
had a problem deploying
to
testing
GitHub Actions
Failure
Bennett-Petzold
had a problem deploying
to
testing
GitHub Actions
Error
Bennett-Petzold
had a problem deploying
to
testing
GitHub Actions
Failure
Bennett-Petzold
had a problem deploying
to
testing
GitHub Actions
Failure
Bennett-Petzold
temporarily deployed
to
testing
GitHub Actions
Inactive
Bennett-Petzold
had a problem deploying
to
testing
GitHub Actions
Failure
Bennett-Petzold
had a problem deploying
to
testing
GitHub Actions
Failure
Bennett-Petzold
had a problem deploying
to
testing
GitHub Actions
Failure
Bennett-Petzold
had a problem deploying
to
testing
GitHub Actions
Failure
Bennett-Petzold
had a problem deploying
to
testing
GitHub Actions
Error
Bennett-Petzold
had a problem deploying
to
testing
GitHub Actions
Failure
Bennett-Petzold
had a problem deploying
to
testing
GitHub Actions
Failure
Bennett-Petzold
had a problem deploying
to
testing
GitHub Actions
Failure
Bennett-Petzold
had a problem deploying
to
testing
GitHub Actions
Error
Bennett-Petzold
had a problem deploying
to
testing
GitHub Actions
Error
Bennett-Petzold
had a problem deploying
to
testing
GitHub Actions
Failure
The two lanes actually improves performance compared to the base design.
Bennett-Petzold
had a problem deploying
to
testing
GitHub Actions
Failure
Bennett-Petzold
temporarily deployed
to
testing
GitHub Actions
Inactive
Bennett-Petzold
had a problem deploying
to
testing
GitHub Actions
Failure
Bennett-Petzold
had a problem deploying
to
testing
GitHub Actions
Failure
Bennett-Petzold
had a problem deploying
to
testing
GitHub Actions
Failure
Bennett-Petzold
had a problem deploying
to
testing
GitHub Actions
Error
Bennett-Petzold
had a problem deploying
to
testing
GitHub Actions
Error
Bennett-Petzold
had a problem deploying
to
testing
GitHub Actions
Error
Bennett-Petzold
temporarily deployed
to
testing
GitHub Actions
Inactive
Bennett-Petzold
had a problem deploying
to
testing
GitHub Actions
Failure
Bennett-Petzold
temporarily deployed
to
testing
GitHub Actions
Inactive
Bennett-Petzold
had a problem deploying
to
testing
GitHub Actions
Failure
Bennett-Petzold
had a problem deploying
to
testing
GitHub Actions
Error
Bennett-Petzold
had a problem deploying
to
testing
GitHub Actions
Error
Bennett-Petzold
had a problem deploying
to
testing
GitHub Actions
Error
Bennett-Petzold
had a problem deploying
to
testing
GitHub Actions
Failure
Bennett-Petzold
had a problem deploying
to
testing
GitHub Actions
Failure
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| instruction::{Instruction, InstructionEnum, InstructionErr, InsufficientPerms}, | ||
| defs::{ | ||
| HalfLC3Word, LC3MemAddr, LC3Word, RegAddr, DISPLAY_DATA_REGISTER, DISPLAY_STATUS_REGISTER, | ||
| KEYBOARD_DATA_REGISTER, KEYBOARD_INTERRUPT, KEYBOARD_STATUS_REGISTER, STACK_REG, |
Check warning
Code scanning / clippy
unused imports: IJumpSubRoutine and KEYBOARD_INTERRUPT Warning
| KEYBOARD_DATA_REGISTER, KEYBOARD_INTERRUPT, KEYBOARD_STATUS_REGISTER, STACK_REG, | ||
| }, | ||
| instruction::{ | ||
| IJumpSubRoutine, Instruction, InstructionEnum, InstructionErr, InsufficientPerms, |
Check warning
Code scanning / clippy
unused imports: IJumpSubRoutine and KEYBOARD_INTERRUPT Warning
| @@ -0,0 +1,46 @@ | |||
| //! Generically defined executors | |||
|
|
|||
| use std::future::{ready, Ready}; | |||
Check warning
Code scanning / clippy
unused imports: Ready and ready Warning
| @@ -0,0 +1,46 @@ | |||
| //! Generically defined executors | |||
|
|
|||
| use std::future::{ready, Ready}; | |||
Check warning
Code scanning / clippy
unused imports: Ready and ready Warning
|
|
||
| use crate::{ | ||
| executors::LC3, | ||
| instruction::{InstructionEnum, Trap}, |
Check warning
Code scanning / clippy
unused imports: InstructionEnum and Trap Warning
|
|
||
| use crate::{ | ||
| executors::LC3, | ||
| instruction::{InstructionEnum, Trap}, |
Check warning
Code scanning / clippy
unused imports: InstructionEnum and Trap Warning
| instruction::{InstructionEnum, Trap}, | ||
| }; | ||
|
|
||
| use super::{r#async::AsyncHarness, sync::SyncHarness, ExecutionFailure}; |
Check warning
Code scanning / clippy
unused import: r#async::AsyncHarness Warning
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.