Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Summary
solve_ram_witness,MultiplicitiesForRange,MultiplicitiesForBinOp, andMultiplicitiesForSpreadSpiceWitnessesSolver::solve,WitnessBuilderSolver::solve, andsolve_witness_vecto returnanyhow::Result<()>instead of panickingprove_with_witnessMotivation
Addresses audit finding Issue H: unchecked witness-derived indices allowed malformed witness values to cause
deterministic out-of-bounds panics in the prover, enabling denial-of-service against proof generation.
Vulnerable sites fixed
ram.rs— Load/Storeaddr.into_bigint().0[0] as usizeused to indexrt_final/rv_finalwithout bounds checkwitness_builder.rs—MultiplicitiesForRangevalue as usizeused as index intomultiplicitieswithout checkingvalue < range_sizewitness_builder.rs—MultiplicitiesForBinOp(lhs << atomic_bits) + rhsused as unchecked table indexwitness_builder.rs—MultiplicitiesForSpreadval as usizeused as unchecked table index (same pattern, not in audit)