Open
Conversation
max5it
reviewed
Jul 29, 2020
|
|
||
| def uid | ||
| raw_info['user']['id'] | ||
| raw_info.dig('user', 'id') |
There was a problem hiding this comment.
raw_info['user']['id'] comes from the original gem. We may want to keep it because if the original upstream gem is updated, here we will have a conflict
| raw_info['user_id'] | ||
| end | ||
|
|
||
| def identity_access_token |
There was a problem hiding this comment.
Duplicated code. Do you want to move it to BaseResponseAdapter?
omniauth-slack.gemspec
Outdated
| spec.add_runtime_dependency 'omniauth-oauth2', "~> 1.3.1" | ||
|
|
||
| spec.add_development_dependency "bundler", "~> 1.3" | ||
| spec.add_development_dependency "bundler" |
max5it
approved these changes
Jul 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://api.slack.com/authentication/oauth-v2#obtaining