WA-VERIFY-109: Rails 7.0 deprecation warning sweep (March 2026)#1133
Open
kitcommerce wants to merge 1 commit intonextfrom
Open
WA-VERIFY-109: Rails 7.0 deprecation warning sweep (March 2026)#1133kitcommerce wants to merge 1 commit intonextfrom
kitcommerce wants to merge 1 commit intonextfrom
Conversation
Run static deprecation analysis against core/admin/storefront under the Rails 7.0 appraisal. Dynamic test run blocked by pre-existing gemspec required_ruby_version format issue (comma-in-single-string rejected by Ruby 3.2.x RubyGems — regression from WA-VERIFY-080). Static analysis findings (8 indicators reviewed): - config.secret_token in admin dummy: silently ignored, N/A - config.load_defaults 6.1 in dummy apps: supported, no warning - ActiveSupport::Deprecation.new: valid in 7.0, guarded for 7.1+ - scoped_tags warn(): Workarea-internal, not a Rails deprecation - BSON Symbol type: fixed in WA-NEW-010 - action_dispatch.rack_cache: guarded via Rails version check - to_s(:format) usage: covered by 28_to_fs_polyfill.rb - to_time_preserves_timezone=false: guarded for Rails 7.0+ in defaults New untracked warnings: 0 — PASS Notes: notes/WA-VERIFY-109-deprecation-sweep-2026-03.md Fixes #1128
kitcommerce
added
review:architecture-pending
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Periodic Rails 7.0 deprecation warning sweep per issue #1128.
Static analysis of
core/,admin/,storefront/production-code paths reviewed 8 deprecation indicators. No new untracked warnings found.Findings
config.secret_tokenin admin dummyconfig.load_defaults 6.1in dummy appsActiveSupport::Deprecation.newscoped_tagsdeprecation warningaction_dispatch.rack_cacheaccessto_s(:format)usageto_time_preserves_timezone = falseNew untracked warnings: 0 — PASS
Dynamic Test Run Blocker (Pre-existing)
BUNDLE_GEMFILE=gemfiles/rails_7_0.gemfile bundle exec rake testfails at gemspec parse:This is a regression from WA-VERIFY-080 which converted the
required_ruby_versionfrom Array to comma-in-single-string form. Ruby 3.2.x's RubyGems rejects the comma-in-single-string format. The fix is to revert to Array form:['>= 2.7.0', '< 3.5.0']. A follow-up issue should be opened to unblock appraisal-based test execution.Notes File
notes/WA-VERIFY-109-deprecation-sweep-2026-03.mdAcceptance Criteria
notes/WA-VERIFY-109-deprecation-sweep-2026-03.mdClient Impact
None — test run only (notes file addition).