Skip to content

WA-VERIFY-107: Audit load_defaults behavioral flags coverage (Rails 7.0/7.1)#1132

Open
kitcommerce wants to merge 1 commit intonextfrom
issue-1126-wa-verify-107-load-defaults-audit
Open

WA-VERIFY-107: Audit load_defaults behavioral flags coverage (Rails 7.0/7.1)#1132
kitcommerce wants to merge 1 commit intonextfrom
issue-1126-wa-verify-107-load-defaults-audit

Conversation

@kitcommerce
Copy link
Contributor

Summary

Adds notes/WA-VERIFY-107-load-defaults-audit.md — a complete coverage audit of all config.load_defaults behavioral flags introduced in Rails 7.0 and 7.1, mapped to Workarea's actual test and documentation state.

Closes #1126

What was audited

  • Current load_defaults version in all three engine dummy apps
  • Every Rails 7.0 versioned default flag
  • Every Rails 7.1 versioned default flag
  • QueryCache middleware position and test coverage
  • BigDecimal/Money cache round-trip test coverage

Key findings

PASS (2)

  • All engine dummy apps consistently pinned to load_defaults 6.1
  • QueryCache middleware is present and cache-between-request isolation is tested ✅

N/A (9)

  • 7 ActiveRecord-only flags (Workarea uses Mongoid)
  • cookies_same_site_protection — compatible with Workarea's cookie usage
  • cache_format_version 7.1 — deploy-procedure concern, already documented in pattern doc

NEEDS-FOLLOW-UP (4 gaps identified)

  1. BigDecimal/Money cache round-trip — no automated regression test exists; silent precision loss possible at cache layer
  2. raise_on_open_redirects — open-redirect paths in Workarea controllers not explicitly verified
  3. active_job.use_big_decimal_serializer — no job-argument round-trip test for BigDecimal/Money values
  4. add_autoload_paths_to_load_path = false — blocked on Mongoid 8; cannot validate until 7.1 appraisal bundles

Files changed

  • notes/WA-VERIFY-107-load-defaults-audit.md (new)

Client impact

None — documentation and verification only, no code changes.

….0/7.1)

Adds notes/WA-VERIFY-107-load-defaults-audit.md documenting the coverage
status of all config.load_defaults behavioral flags introduced in Rails 7.0
and 7.1.

Key findings:
- All three engine dummy apps consistently pinned to load_defaults 6.1 (PASS)
- QueryCache middleware presence and no-leak behavior is tested (PASS)
- 9 flags are N/A (ActiveRecord-only, or deploy-procedure concerns)
- 4 gaps flagged as NEEDS-FOLLOW-UP:
  * No BigDecimal/Money cache round-trip regression test
  * raise_on_open_redirects not verified against Workarea controllers
  * active_job.use_big_decimal_serializer not tested for job args
  * add_autoload_paths_to_load_path = false not yet validated (blocked on Mongoid 8)

Closes #1126
@kitcommerce kitcommerce added review:architecture-pending Review in progress review:simplicity-pending Review in progress review:security-pending Review in progress review:rails-conventions-pending Rails conventions review in progress labels Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review:architecture-pending Review in progress review:rails-conventions-pending Rails conventions review in progress review:security-pending Review in progress review:simplicity-pending Review in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant