WA-VERIFY-102: Audit BigDecimal.new usage

[kitcommerce]

Fixes #1105

Summary

• Audited the repo for deprecated BigDecimal.new usage (no call sites found).
• Enabled RuboCop's Lint/BigDecimalNew cop to prevent future reintroduction.

Testing

• N/A (static analysis configuration change only)

Client impact

None expected.

[kitcommerce]

Wave 1 Review Results

architecture: PASS — lint-only change; no runtime coupling.
simplicity: PASS — enabling the cop is the smallest enforcement mechanism.
security: PASS — reduces risk of Ruby 3.4 breakage; no security impact.
rails-conventions: PASS_WITH_NOTES — this assumes the repo’s RuboCop version includes (CI passed here, but downstream apps on older RuboCop may need a bump to benefit).

Wave 1 PASSED. Good to proceed to Wave 2 / merge.

[kitcommerce]

(Minor fix) The cop name referenced above is: .

[kitcommerce]

(Minor fix) The cop name referenced above is: Lint/BigDecimalNew.

[kitcommerce]

Wave2 review (PR #1106)

{"reviewer":"test-quality","verdict":"PASS","severity":null,"summary":"Lint-only change; no test coverage concerns.","findings":[]}

{"reviewer":"architecture","verdict":"PASS","severity":null,"summary":"Static analysis configuration only; no architecture impact.","findings":[]}

{"reviewer":"database","verdict":"PASS","severity":null,"summary":"No database impact.","findings":[]}

{"reviewer":"security","verdict":"PASS","severity":null,"summary":"No security impact.","findings":[]}

{"reviewer":"rails-security","verdict":"PASS","severity":null,"summary":"No Rails security impact.","findings":[]}

{"reviewer":"simplicity","verdict":"PASS","severity":null,"summary":"Small, focused RuboCop config addition.","findings":[]}

{"reviewer":"rails-conventions","verdict":"PASS_WITH_NOTES","severity":"LOW","summary":"Looks fine; just ensure our RuboCop version supports the cop in all supported branches.","findings":[{"severity":"LOW","file":".rubocop.yml","line":1,"issue":"Enabling a new cop can break CI if a downstream environment pins an older RuboCop without Lint/BigDecimalNew.","suggestion":"If any supported branches pin older RuboCop, consider gating via TargetRubyVersion/RuboCop upgrade, or document minimum RuboCop version."}]}

[kitcommerce]

⚠️ Merge conflict detected (mergeStateStatus: DIRTY). Cannot auto-merge. Blocking for resolution.

[kitcommerce]

⚠️ Merge Conflict

Auto-merge blocked: mergeStateStatus: DIRTY — branch has conflicts with next. Rebasing required before merge can proceed.

Please rebase on next and push to resolve.

[kitcommerce]

⚠️ Merge conflict detected. Please rebase on next and push to re-enter the merge queue.