Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Removes an out-of-place SSL initialization call from the socket shutdown path to prevent redundant/secondary exceptions during close() after handshake/init failures, unblocking a failing SunJSSE test.
Changes:
- Removes
checkAndInitSSLSocket()invocation fromWolfSSLSocket.close() - Eliminates the associated close-path comment that suggested SSL init during shutdown
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cconlon
requested changes
Apr 9, 2026
f793797 to
768ffcc
Compare
…in wrap() if inbound is already closed
768ffcc to
4d7a3ea
Compare
cconlon
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
checkAndInitSSLSocket()call inWolfSSLSocket.close(). Function is meant to be called when initializing SSL Socket. Calling during close is counter-intuitive and causes a second, unnecessary exception to be thrown if connection failed duringcheckAndInitSSLSocket()atEngineHelper.loadKeyAndCertChain().Fixes SunJSSE test
NetSSLCiphersuites/ECCurvesconstraints.javaSets
this.closed = truewhen receiving aFATAL_ALERTinunwrap()or if buffered data was sent, inbound was closed and close_notify sent inwrap(). Buffer should not receive any more data.Fixes SunJSSE tests
SSLEngine/EngineCloseOnAlert.javaandSSLEngineImpl/SSLEngineFailedALPN.java