Skip to content

Info page: Total LEDs, GitHub repo, minor re-styling#5418

Merged
softhack007 merged 2 commits intomainfrom
info_updates
Mar 11, 2026
Merged

Info page: Total LEDs, GitHub repo, minor re-styling#5418
softhack007 merged 2 commits intomainfrom
info_updates

Conversation

@softhack007
Copy link
Member

@softhack007 softhack007 commented Mar 11, 2026

  • added GitHub repo (link)
  • added Total LEDs
  • removed lwip major version on esp32
  • two horizontal lines for better readability
image

Summary by CodeRabbit

  • New Features

    • Device information now displays total LED count.
    • Device information now includes a direct link to the device's GitHub repository.
  • UI Improvements

    • Information sections are separated with additional visual dividers for better readability.
    • Environment details are streamlined to show only applicable fields (omitting empty values).

* added GitHub repo (link)
* added Total LEDs
* two horizontal lines for better readability
Copilot AI review requested due to automatic review settings March 11, 2026 16:35
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 11, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 5b77aa23-6fb1-444a-a535-d073e3421a81

📥 Commits

Reviewing files that changed from the base of the PR and between 4f41a5f and 23f8687.

📒 Files selected for processing (1)
  • wled00/data/index.js
🚧 Files skipped from review as they are similar to previous changes (1)
  • wled00/data/index.js

Walkthrough

This change updates the info table in wled00/data/index.js: adds horizontal rules to separate sections, inserts a Total LEDs row and a GitHub repository row (both conditional), and makes the Environment row show lwip only when present.

Changes

Cohort / File(s) Summary
UI Info Table Updates
wled00/data/index.js
Inserted horizontal rule separators; added conditional Total LEDs row (i.leds.count) and conditional GitHub row (i.repo); modified Environment row to include i.lwip only when truthy; preserved existing rows and structure.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main changes: adding Total LEDs display, GitHub repo link, and visual styling improvements with horizontal rules.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch info_updates

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

This comment was marked as duplicate.

coderabbitai[bot]

This comment was marked as resolved.

When using target="_blank", it's a security best practice to include rel="noopener noreferrer" to prevent the new page from accessing window.opener.
Copy link
Collaborator

@DedeHai DedeHai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did not test but looks good to me

@softhack007
Copy link
Member Author

Thanks, I'll merge it.

Especially the "repo" line should also help us for user support.

I'll also cherry-pick it to 0.15.4 - its a low-risk change and the necessary info is present in 0.15, too.

@softhack007 softhack007 merged commit e4cd730 into main Mar 11, 2026
53 checks passed
@softhack007 softhack007 deleted the info_updates branch March 11, 2026 17:07
softhack007 added a commit that referenced this pull request Mar 11, 2026
* Info page updates and minor re-styling
  * added GitHub repo (link)
  * added Total LEDs
  *  removed lwip major version on esp32
  * two horizontal lines for better readability

* add rel="noopener noreferrer" for improved security
  * When using target="_blank", it's a security best practice to include rel="noopener noreferrer" to prevent the new page from accessing window.opener.
softhack007 added a commit to MoonModules/WLED-MM that referenced this pull request Mar 11, 2026
* Info page updates and minor re-styling
  * added GitHub repo (link)
  * added Total LEDs
  *  removed lwip major version on esp32
  * two horizontal lines for better readability

* add rel="noopener noreferrer" for improved security
  * When using target="_blank", it's a security best practice to include rel="noopener noreferrer" to prevent the new page from accessing window.opener.
@netmindz
Copy link
Member

It looks like the font style is different for the repo value.

Speaking of repo, we should also replace the hard codes repo used for the release badge on the upgrade page as well

@netmindz
Copy link
Member

netmindz commented Mar 11, 2026

Did you notice I added the release name to the info panel?

@softhack007
Copy link
Member Author

Hi @netmindz

Did you notice I added the release name to the info panel?

yep 😃

It looks like the font style is different for the repo value.

Its a URL (clickable), maybe that causes the slightly different style?

Speaking of repo, we should also replace the hard codes repo used for the release badge on the upgrade page as well

good point, i'll check if that's easy to do - not sure if the upgrade page can access i.repo.

@softhack007
Copy link
Member Author

softhack007 commented Mar 11, 2026

@netmindz good catch about the release badge.

There is some behind-the-scenes replacement already ongoing in cdata.js, but this does not catch the badge because the URL is slightly different:

<img src="https://img.shields.io/github/release/wled-dev/WLED.svg?style=flat-square"></a><br>

WLED/tools/cdata.js

Lines 94 to 103 in e4cd730

function adoptVersionAndRepo(html) {
let repoUrl = packageJson.repository ? packageJson.repository.url : undefined;
if (repoUrl) {
repoUrl = repoUrl.replace(/^git\+/, "");
repoUrl = repoUrl.replace(/\.git$/, "");
html = html.replaceAll("https://github.com/atuline/WLED", repoUrl);
html = html.replaceAll("https://github.com/wled-dev/WLED", repoUrl);
}
let version = packageJson.version;
if (version) {

I'll check if the badge can be replaced the same way at build time.

Edit: PR created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants