Info page: Total LEDs, GitHub repo, minor re-styling#5418
Conversation
* added GitHub repo (link) * added Total LEDs * two horizontal lines for better readability
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThis change updates the info table in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
When using target="_blank", it's a security best practice to include rel="noopener noreferrer" to prevent the new page from accessing window.opener.
DedeHai
left a comment
There was a problem hiding this comment.
did not test but looks good to me
|
Thanks, I'll merge it. Especially the "repo" line should also help us for user support. I'll also cherry-pick it to 0.15.4 - its a low-risk change and the necessary info is present in 0.15, too. |
* Info page updates and minor re-styling * added GitHub repo (link) * added Total LEDs * removed lwip major version on esp32 * two horizontal lines for better readability * add rel="noopener noreferrer" for improved security * When using target="_blank", it's a security best practice to include rel="noopener noreferrer" to prevent the new page from accessing window.opener.
* Info page updates and minor re-styling * added GitHub repo (link) * added Total LEDs * removed lwip major version on esp32 * two horizontal lines for better readability * add rel="noopener noreferrer" for improved security * When using target="_blank", it's a security best practice to include rel="noopener noreferrer" to prevent the new page from accessing window.opener.
|
It looks like the font style is different for the repo value. Speaking of repo, we should also replace the hard codes repo used for the release badge on the upgrade page as well |
|
Did you notice I added the release name to the info panel? |
|
Hi @netmindz
yep 😃
Its a URL (clickable), maybe that causes the slightly different style?
good point, i'll check if that's easy to do - not sure if the upgrade page can access |
|
@netmindz good catch about the release badge. There is some behind-the-scenes replacement already ongoing in Line 63 in e4cd730 Lines 94 to 103 in e4cd730 I'll check if the badge can be replaced the same way at build time. Edit: PR created |
Summary by CodeRabbit
New Features
UI Improvements