Migrate FloatingButton to use new ScreenFooter component internally#3948
Migrate FloatingButton to use new ScreenFooter component internally#3948
Conversation
✅ PR Description Validation PassedAll required sections are properly filled out:
Your PR is good for review! 🚀 This validation ensures all sections from the PR template are properly filled. |
|
few things regarding the migration -
|
|
lidord-wix
left a comment
There was a problem hiding this comment.
I added some comments, overall looks good :)
Please make the changelog (in the PR description) more clear 🙏🏽
Also - I wasn't able to run locally, had some issues with the yarn install.. will try again tomorrow
packages/react-native-ui-lib/src/components/floatingButton/__tests__/index.spec.tsx
Show resolved
Hide resolved
packages/react-native-ui-lib/src/components/floatingButton/__tests__/index.spec.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
please format all files before merging the PR (cmd + shift + P -> Format Document) make sure you're doing it with Prettier ESlint (cmd + shift + P -> Format Document With)
…figurations. added api.json support
|
@yotam-wix I was able to run it locally and it looks good :) |
lidord-wix
left a comment
There was a problem hiding this comment.
Approved :)
don't forget to format the files before merging :)
Description
Changelog
floatingButton - changed to use new ScreenFooter component internally. deprecated original component.
Additional info
Ticket 5000