Skip to content

Seperate go build from go build-and-test#170

Merged
chriskarlin merged 10 commits intomainfrom
skip-test
Mar 28, 2025
Merged

Seperate go build from go build-and-test#170
chriskarlin merged 10 commits intomainfrom
skip-test

Conversation

@chriskarlin
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

@dcbickfo dcbickfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you managed this in a different way, but my vote would be to have a separate build action (like what we had when I was playing with caching) and let the calling workflow skip running the tests rather than skipping part of this action.

@chriskarlin chriskarlin changed the title add skip test flag Seperate go build from go build-and-test Mar 28, 2025
@chriskarlin chriskarlin requested a review from dcbickfo March 28, 2025 17:12
@gitstream-cm
Copy link
Copy Markdown

gitstream-cm bot commented Mar 28, 2025

This PR is missing a Jira ticket reference in the title or description.
Please add a Jira ticket reference to the title or description of this PR.

@chriskarlin
Copy link
Copy Markdown
Contributor Author

@dcbickfo good idea, I went ahead with this approach

@gitstream-cm
Copy link
Copy Markdown

gitstream-cm bot commented Mar 28, 2025

🥷 Code experts: no user matched threshold 10

See details

go/build-and-test/action.yml

Knowledge based on git-blame:

To learn more about /:\ gitStream - Visit our Docs

@chriskarlin chriskarlin requested a review from dcbickfo March 28, 2025 18:31
@chriskarlin
Copy link
Copy Markdown
Contributor Author

chriskarlin commented Mar 28, 2025

This could really be scraped if we call
wishabi/github-actions/go/configure@v0 + wishabi/github-actions/go/deps@v0 + wishabi/github-actions/go/test@v0
instead of
wishabi/github-actions/go/build-and-test@v0
from distribution-api

id: get-short-sha
run: echo "short_sha=`echo ${GITHUB_SHA::7}`" > $GITHUB_OUTPUT
shell: bash
- name: Configure Go environment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this one need configure and the old build and test action didnt?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it did :P
image

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read the diff wrong

@dcbickfo
Copy link
Copy Markdown
Contributor

This could really be scraped if we call wishabi/github-actions/go/configure@v0 + wishabi/github-actions/go/deps@v0 + wishabi/github-actions/go/test@v0 instead of wishabi/github-actions/go/build-and-test@v0 from distribution-api

I feel like that might be taking us full circle. I think we were doing that at some point 😂

@chriskarlin chriskarlin requested a review from dcbickfo March 28, 2025 21:04
@chriskarlin chriskarlin merged commit dbfbe32 into main Mar 28, 2025
6 checks passed
@chriskarlin chriskarlin deleted the skip-test branch March 28, 2025 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants