feat: accept redis client in rate limit RedisBackend#393
Open
ComeBertrand wants to merge 1 commit intomasterfrom
Open
feat: accept redis client in rate limit RedisBackend#393ComeBertrand wants to merge 1 commit intomasterfrom
ComeBertrand wants to merge 1 commit intomasterfrom
Conversation
dbe39f6 to
ed5c847
Compare
There was a problem hiding this comment.
Pull request overview
Adds support for supplying a pre-built redis.Redis client to the rate limit RedisBackend, so the backend can reuse an existing connection_pool instead of always constructing storage from a URL—aligning rate-limit Redis behavior with other Remoulade Redis backends.
Changes:
- Extend
remoulade.rate_limits.backends.RedisBackendto acceptclientand makeurloptional, raising when neither is provided. - Add/adjust test fixtures to exercise rate limiting against stub, Redis-by-URL, and Redis-by-client backends.
- Add a unit test asserting
RedisBackend()requires eitherurlorclient.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
remoulade/rate_limits/backends/redis.py |
Accept optional client, optional url, and build limits Redis storage from a provided connection pool. |
tests/conftest.py |
Introduce fixtures for Redis rate-limit backends (URL/client) and parametrize rate_limit_backend. |
tests/middleware/test_rate_limit.py |
Add a test for the “url or client required” constructor validation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Allow passing a pre-built redis.Redis client as an alternative to a URL. When a client is provided, its connection_pool is reused by the limits RedisStorage, consistent with other remoulade Redis backends.
ed5c847 to
c7abc33
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow passing a pre-built redis.Redis client as an alternative to a URL. When a client is provided, its connection_pool is reused by the limits RedisStorage, consistent with other remoulade Redis backends.