Closed
Conversation
Not using a callback is deprecated. Errors should properly be handled and this adds callback to do so.
Contributor
Author
|
@indexzero PTAL. |
4 tasks
jcrugzz
approved these changes
Feb 26, 2018
This was referenced Mar 6, 2018
Member
|
This needs to be back-ported onto |
Member
|
@BridgeAR thank you for your contribution. Going to close this in preference of #1227 and #1228. From the perspective of the caller any errors arising out of closing the file descriptor are safe to ignore since:
If the permissions of the file change during that time then the error itself is probably not all that useful. Willing to reconsider this position if tests are provided illustrating how handling this error is important. |
Contributor
Author
|
I am fine with #1227. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not using a callback is deprecated. Errors should properly be
handled and this a adds callback to do so.
Refs: nodejs/node#18668