Add option to wholesale replace the timestamp property with another#305
Open
bytenik wants to merge 3 commits intowinstonjs:masterfrom
Open
Add option to wholesale replace the timestamp property with another#305bytenik wants to merge 3 commits intowinstonjs:masterfrom
bytenik wants to merge 3 commits intowinstonjs:masterfrom
Conversation
Contributor
|
I think this looks ok to me, once linting and other tests pass |
Contributor
|
@bytenik getting a test failure in the timestamp test but once that is resolved this should be ok |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alias is not enough if your application routinely also uses timestamp for something else.