Added FreeBSD Support and instrcutions#88
Closed
sandronoel wants to merge 2 commits intowindy1:masterfrom
Closed
Conversation
windy1
requested changes
Dec 24, 2025
Contributor
Author
|
I figured. But I did not want to disturb anything in case I messed things up :)
I’ll do the replacements.
… On Dec 23, 2025, at 7:30 PM, Walker Crouse ***@***.***> wrote:
@windy1 requested changes on this pull request.
In zeroconf/src/bonjour/browser.rs <#88 (comment)>:
> @@ -325,6 +327,14 @@ unsafe fn handle_get_address_info(
IpAddr::from(s_addr).to_string()
};
+ #[cfg(target_os = "freebsd")]
Since this block is identical, we should probably just update the "apple" directive to also include "freebsd", instead of copy/pasting.
In zeroconf/src/ffi/mod.rs <#88 (comment)>:
> @@ -132,3 +132,43 @@ pub(crate) mod bonjour {
}
}
}
+
+#[cfg(target_os = "freebsd")]
Same here, if the block is the same, there is really no need to duplicate it. You can use any e.g.
#[cfg(any(target_vendor = "apple", target_os = "freebsd"))]
—
Reply to this email directly, view it on GitHub <#88 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AG5SWHWOGF3RQB7JA6SPCDT4DH3FVAVCNFSM6AAAAACP3XIT7WVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTMMBZG42TGOBYHE>.
You are receiving this because you authored the thread.
|
Owner
|
@sandronoel Thank you for your patience. I recently moved, so things are a bit chaotic for me at the moment. I will try to give a proper review ASAP. |
Contributor
Author
|
Life is more important. Please don’t worry about it.
Regards.
Sandro.
… On Jan 3, 2026, at 8:10 AM, Walker Crouse ***@***.***> wrote:
windy1
left a comment
(windy1/zeroconf-rs#88)
<#88 (comment)>
@sandronoel <https://github.com/sandronoel> Thank you for your patience. I recently moved, so things are a bit chaotic for me at the moment. I will try to give a proper review ASAP.
—
Reply to this email directly, view it on GitHub <#88 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AG5SWHQCF5XUMBI3X7SN5SD4E7LX5AVCNFSM6AAAAACP3XIT7WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTOMBXGEZDANZYGE>.
You are receiving this because you were mentioned.
|
Merged
Owner
|
Merged in 7d5e632 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added FreeBSD Support, I tested it on FreeBSD 15, with the mDNSResponder package installed.