Merged
Conversation
Signed-off-by: Walker Crouse <walkercrouse@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Brief summary of these changes and their impact. The easier it is to follow and understand, the easier to review.
Why
Reason for these changes. And why not some other changes (if applicable). Context here can be helpful when later blaming this code/reading logs.
Manual Tests
What did you do to verify your changes?
Documentation Updates
Did you document the purpose of any new code? Did you add comments explaining anything that might look strange to
someone trying to figure out what your code is doing a year from now who doesn't know the full context? Is the README
for this repo still accurate and useful?