Closed
Conversation
Otherwise the user wouldn't see any events unless they also set RUST_LOG
windy1
requested changes
Apr 6, 2025
Owner
windy1
left a comment
windy1
left a comment
There was a problem hiding this comment.
I'm sorry it's taken so long to take a look at this. LGTM besides the one minor comment.
windy1
approved these changes
Apr 23, 2025
Merged
Owner
|
Moved to #80 because the GH Actions workflow is not triggering, and I don't know why. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The library currently only listens to events indicating that a new service is found but not when zeroconf detects a service is removed. Detecting service disconnection is useful for long running apps which would otherwise, over time, collect many no longer active services.
This PR renames and modifies the
TMdnsBrowser::set_service_discovered_callbacktrait function and changes its Avahi and Bonjour implementations to also handle service removal events.Further discussion in issue #67
Tested these changes on Linux/Avahi and MacOS/Bonjour.
Note that this is an API breaking change.