Add an option to invalidate GPG keys#880
Conversation
|
A preview of this PR is available at https://pr-880-wildfly-org.surge.sh |
data/contributors.yaml
Outdated
| link: https://keys.openpgp.org/vks/v1/by-fingerprint/51F8871824A19B8C3EE6708AC34DC24F80C9A5BA | ||
| fingerprint: 51F8 8718 24A1 9B8C 3EE6 708A C34D C24F 80C9 A5BA | ||
| invalidated: 2026-03-10 | ||
| invalidated-reason: No longer available |
There was a problem hiding this comment.
I've left this free-form, but I'm not sure what we want to do here. We could have defined reasons or leave it free-formed like this. "No longer available" might also not be a great reason :)
| @@ -0,0 +1,54 @@ | |||
| /* | |||
There was a problem hiding this comment.
Why add this and delete Contributors.java? Roq should handle all of this for us.
There was a problem hiding this comment.
I got errors with the use of java.time.LocalDate. There is a chance I did something wrong, but I got errors with the BytecodeRecorderImpl.
There was a problem hiding this comment.
Seems to be a long-standing issue. I've filed an issue upstream: quarkiverse/quarkus-roq#779
Signed-off-by: James R. Perkins <jperkins@ibm.com>
jamezp
force-pushed
the
invalidated-pgp-keys
branch
from
82bd76c to
a0c5a8f
Compare
bstansberry
left a comment
bstansberry
left a comment
There was a problem hiding this comment.
I think you should remove the contributors.yaml change. We should merge this and then we should ask Pedro to update and sign his commit.
Let's avoid edits to these records by people other than the key owner.
|
No problem. I'll remove it now. Part of adding was to see what it would look like, but it makes sense that the owner of the key should change it. |
jamezp
force-pushed
the
invalidated-pgp-keys
branch
from
a0c5a8f to
2d35013
Compare
|
yeah, using it to test the result made sense |
jamezp
changed the title
|
Thanks @jamezp and @jasondlee |
3 participants
No description provided.