Open
Conversation
Owner
|
I don't really like the idea of passing a global "all_stats" variable to all the assets. I think it would make more sense if each asset implements a "get_stats" method. This method can use the values already retrieved in "get_values" (maybe we can even call it "get_extra_values" because it's not really statistics at that point). It can also return different classes, e.g. a bank asset can return a "StatBank" instance (or call it a "BankValues" instance, for example). Then we can aggregate the values in the new stats.py file based on the instance type again. Something like that. Makes sense? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.