Skip to content

refactor: remove command specific previews from PRIVATE_COMMANDS#501

Merged
wfxr merged 1 commit intowfxr:mainfrom
sandr01d:remove-preview-commands
Mar 17, 2026
Merged

refactor: remove command specific previews from PRIVATE_COMMANDS#501
wfxr merged 1 commit intowfxr:mainfrom
sandr01d:remove-preview-commands

Conversation

@sandr01d
Copy link
Collaborator

@sandr01d sandr01d commented Mar 16, 2026

Check list

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have added unit tests for my code
  • I have made corresponding changes to the documentation

Description

These are no longer necessary due to the new preview function introduced in #498.

Type of change

  • Bug fix
  • New feature
  • Refactor
  • Breaking change
  • Test
  • Documentation change

Test environment

  • Shell
    • bash
    • zsh
    • fish
  • OS
    • Linux
    • Mac OS X
    • Windows
    • Others:

Summary by CodeRabbit

  • Chores
    • Reorganized internal command structure, removing preview command restrictions and adding worktree list management.

These are no longer necessary due to the new `preview` function
@coderabbitai
Copy link

coderabbitai bot commented Mar 16, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3730476c-2284-4cbb-ae1b-ebd0cdf87b10

📥 Commits

Reviewing files that changed from the base of the PR and between f7e2d43 and 4e60216.

📒 Files selected for processing (1)
  • bin/git-forgit
💤 Files with no reviewable changes (1)
  • bin/git-forgit

📝 Walkthrough

Walkthrough

The PR modifies the PRIVATE_COMMANDS array in bin/git-forgit by removing 16 preview-related command references and adding worktree_list_deletable. These removals effectively expose the preview commands from private to public scope without altering core dispatch logic.

Changes

Cohort / File(s) Summary
Command Registry Update
bin/git-forgit
Removed 16 preview command entries from PRIVATE_COMMANDS (add_preview, blame_preview, branch_preview, checkout_commit_preview, checkout_file_preview, cherry_pick_from_branch_preview, cherry_pick_preview, clean_preview, file_preview, path_preview, revert_preview, reset_head_preview, show_preview, stash_show_preview, log_preview, worktree_preview) and added worktree_list_deletable.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • cjappl
  • carlfriedrich

Poem

🐰 With a hop and a bound, the previews run free!
No longer concealed where they shouldn't be,
From private to public, they leap with delight,
While worktree_list joins the command-line night.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: removing preview-related commands from PRIVATE_COMMANDS, which matches the refactoring work in this PR.
Description check ✅ Passed The description includes all required template sections: checklist (self-review completed), description with context about PR #498, type of change (Refactor), and test environment (zsh on Linux).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can use Trivy to scan for security misconfigurations and secrets in Infrastructure as Code files.

Add a .trivyignore file to your project to customize which findings Trivy reports.

Copy link
Owner

@wfxr wfxr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wfxr wfxr merged commit 30aff90 into wfxr:main Mar 17, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants