Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix description list wrapped line indentation to use dindent option
Summary
Modified description list (
.dl) processing to make wrapped continuation line indentation configurable via thedindentoption, replacing the hardcoded 2-space indent.Changes
Text Output (ppgen.py)
wrap_def()method (lines 7960-7977): Changed hanging indent calculation to usedindentwhen specifiedemit_paragraph()method (lines 7865-7872): Applied same logic for paragraph/combining modedindent > 0: Usesdindentvalue as the hanging indent amountdindent = 0(default): Maintains backward-compatible 2-space hanging indentHTML Output (ppgen.py)
begin_dl()method (lines 11992-12063): Updated CSS generation for hanging indentsdindentwas shifting the entire definition (including first line) to the rightfloat=yandfloat=nmodesLeading Spaces in Descriptions
|in descriptions weren't being converted to CSS in HTML output.dd_inN) for indent amounts<dd>tags (style=d) and<p>tags (style=p)Behavior
dindent=0preserves existing 2-space hanging indentdindent=4creates 4-space hanging indent for wrapped linesdindentonly affects continuation lines, not first line positionTesting
Verified with multiple test cases:
dindent=0maintains backward compatibilitydindent=4,dindent=6) work correctlycombine=y) and non-combining modes testedhang=yandhang=nmodes work as expected