fix: update node state after installSnapshot#60
Open
Qian-Cheng-nju wants to merge 3 commits intowenweihu86:masterfrom
Open
fix: update node state after installSnapshot#60Qian-Cheng-nju wants to merge 3 commits intowenweihu86:masterfrom
Qian-Cheng-nju wants to merge 3 commits intowenweihu86:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
I noticed that the installSnapshot handler doesn't update commitIndex, lastAppliedIndex, or configuration after applying a snapshot. After a snapshot install with lastIncludedIndex=100, the node continues operating with its old commitIndex (e.g. 5).
The RaftNode constructor (RaftNode.java:88-112) correctly initializes these from snapshot metadata on startup, so this is just a missing update in the runtime installSnapshot path.