fix: implement spec propagation as rolling upgrade#2412
Open
rugggger wants to merge 1 commit into03-30-fix_create_pod-rotation_by_specversion_for_wekacontainersfrom
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd the label main-merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Mar 31, 2026
graphite-app
bot
requested review from
assafgi,
kristina-solovyova and
tigrawap
Graphite Automations"Add anton/matt/sergey/kristina as reviwers on operator PRs" took an action on this PR • (03/31/26)3 reviewers were added to this PR based on Anton Bykov's automation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Extended the upgrade system to support spec-based upgrades in addition to image-based upgrades, allowing coordinated rolling updates when any cluster specification changes.
What changed?
TargetSpecVersionfield toUpgradeControlleralongside the existingTargetImagefieldisContainerAligned()andisContainerApplied()methods to check upgrade status based on either spec version or imageNewUpgradeController()constructor to accept both target image and target spec version parametersCalcClusterSpecVersion()to include additional cluster specification fields like CPU policy, IPv6 settings, network configuration, and encryption settingsLastAppliedSpecstatus field and handle both image and non-image specification changesSpecVersioneven whenallowRotateNonAnnotatedis disabledWhy make this change?
This change enables the operator to perform coordinated rolling updates when any cluster specification changes, not just image updates. Previously, changes to CPU policy, network configuration, or other cluster settings would not trigger proper rolling upgrades, potentially leaving the cluster in an inconsistent state. The new spec version system ensures all containers are updated consistently when any tracked specification field changes.