Skip to content

sets a max on python 3.14 for the moment and fixes CI#1357

Open
bw4sz wants to merge 1 commit intomainfrom
python_max_3.14
Open

sets a max on python 3.14 for the moment and fixes CI#1357
bw4sz wants to merge 1 commit intomainfrom
python_max_3.14

Conversation

@bw4sz
Copy link
Collaborator

@bw4sz bw4sz commented Mar 20, 2026

#1353 I'm setting back to python 3.13 until #1266 is ready.

@bw4sz
Copy link
Collaborator Author

bw4sz commented Mar 20, 2026

@jveitchmichaelis can you merge at least for the short term so that main passes.

@ethanwhite
Copy link
Member

Is this for CI or for local installs?

@jveitchmichaelis
Copy link
Collaborator

Ok so roll back until docformatter gets updated?

@ethanwhite I think it's affecting pre-commit and by extension the CI. But I've not tried updating locally yet.

@ethanwhite
Copy link
Member

If it's just for docformatter in pre commit then it seems like we can just change .pre-commit-config.yaml

@jveitchmichaelis
Copy link
Collaborator

Yeah, I assume it's fine to pin precommit at 3.13

https://pre-commit.com/#top_level-default_language_version

@bw4sz do you tweak the config in this PR and see if that passes?

@henrykironde
Copy link
Contributor

It looks like you’re working from an older branch where the initialization was placed between the imports. This shouldn’t cause errors for users running Python ≤3.14, and developers experimenting with 3.14 should instead use Python ≤3.13 for now. Our pipelines are also expected to run on Python ≤3.13.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants