Modernize dev branch codebase to PHP 7.4+ minimum requirements#148
Open
zhyian wants to merge 9 commits intowecodemore:devfrom
Open
Modernize dev branch codebase to PHP 7.4+ minimum requirements#148zhyian wants to merge 9 commits intowecodemore:devfrom
zhyian wants to merge 9 commits intowecodemore:devfrom
Conversation
- Migrate to typed properties, constructor property promotion, and null-safe operators across all src/ and test files - Replace Psalm with PHPStan for static analysis - Split monolithic php-qa workflow into separate CS, lint, SA, and tests workflows - Drop Composer v1 / RemoteFilesystem support (composer-plugin-api ^2.3) - Drop PHPUnit cross-version compatibility shim (PHPUnit 9.6+ only)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Mirrors the modernization done in
version-3(PR #142) for thedevbranch. Raises the minimum PHP version to 7.4 and updates the codebase, tooling, and CI accordingly.Codebase
src/andtests/files@vardocblocks with native type declarationsStatic analysis
CI / workflows
php-qaworkflow into separatephp-cs,php-lint,php-sa, andphp-testsworkflowsHow has this been tested?
Types of changes
What types of changes does your code introduce?
Bug fixes
ENV_DIRconfig causing crash when not explicitly set:WpConfigStep,VcsIgnoreCheckStep, andEnvExampleStepusedunwrap()which throws on the defaultnullvalue. Changed tounwrapOrFallback('')(dbde344 and 5e40494).New feature
Breaking change (fix or feature that break existing functionality)
Issues
Mirrors #142 for the
devbranch.Checklist: