Port bug fixes from dev branch to version-3#147
Open
zhyian wants to merge 4 commits intowecodemore:version-3from
Open
Port bug fixes from dev branch to version-3#147zhyian wants to merge 4 commits intowecodemore:version-3from
zhyian wants to merge 4 commits intowecodemore:version-3from
Conversation
- Add FILTER_RAW_STRING that uses addslashes() instead of htmlspecialchars()/strip_tags(), preventing corruption of special characters in passwords and secret keys. - Apply FILTER_RAW_STRING to DB_PASSWORD, FTP_PASS, WP_PROXY_PASSWORD, and all AUTH/NONCE/SECRET keys and salts.
- Scan mu-plugins subdirectories that aren't from known wordpress-muplugin packages, so MU plugins installed via installer-paths (e.g. from wp.org, which can't use the wordpress-muplugin type) are properly loaded. - Also filter out dropin files from the scan to avoid loading them twice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ports bug fixes from the
devbranch that also affectversion-3. Each fix was manually adapted toversion-3codebase (PHP 7.4+ typed properties, PHPStan, restructured classes).How has this been tested?
version-3Types of changes
Bug fixes
EnvExampleStep::allowed()andtargetPath()now resolve paths using the configuredENV_DIRinstead of always using the project root. AddedFilesystem::normalizePath()public method to support this.IointoQuestion::filterAnswer(), sostrtoloweris only applied for standard answer-key matching - not unconditionally on all input.&,<,') were corrupted byFILTER_STRING(which runshtmlspecialchars/strip_tags). AddedFILTER_RAW_STRINGusingaddslashes()instead, applied toDB_PASSWORD,FTP_PASS,WP_PROXY_PASSWORD, and allAUTH/NONCE/SECRETkeys and salts.installer-paths(e.g. from wp.org, which can't use thewordpress-muplugintype) were not being loaded. Now scans mu-plugins subdirectories for plugins not covered by known packages, with dropin filtering to avoid double-loading.New feature
Breaking change
Issues
Checklist: