Add missing __Directive.args(includeDeprecated:)#1738
Merged
spawnia merged 2 commits intowebonyx:masterfrom Jul 28, 2025
Gregory-Gerard:missing-directive-args-include-deprecated
Merged
Add missing __Directive.args(includeDeprecated:)#1738spawnia merged 2 commits intowebonyx:masterfrom Gregory-Gerard:missing-directive-args-include-deprecated
__Directive.args(includeDeprecated:)#1738spawnia merged 2 commits intowebonyx:masterfrom
Gregory-Gerard:missing-directive-args-include-deprecated
Conversation
|
Perfect timing — I’ve got the same issue going on. |
Collaborator
|
Let's include the changes from graphql/graphql-js#4354 also. |
Contributor
Author
Done! |
spawnia
reviewed
Jul 28, 2025
Adds the missing includeDeprecated argument to `__Directive.args` field to match GraphQL.js implementation (graphql/graphql-js#3273). The argument allows filtering deprecated directive arguments from introspection results when set to false (default behavior). This notably fixes schema generation with `graphql-codegen` when using the "inputValueDeprecation" option (see dotansimha/graphql-code-generator#9659). Includes tests for deprecated argument filtering that I didn't find in GraphQL.js.
Collaborator
|
Nice work on making a clean change with good commits! |
Collaborator
|
Released with https://github.com/webonyx/graphql-php/releases/tag/v15.22.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey! First time contributing here 👋
Adds the missing includeDeprecated argument to
__Directive.argsfield to match GraphQL.js implementation (graphql/graphql-js#3273) and GraphQL Spec (graphql/graphql-spec#805).The argument allows filtering deprecated directive arguments from introspection results when set to false (default behavior).
This notably fixes schema generation with
graphql-codegenwhen using the "inputValueDeprecation" option (see dotansimha/graphql-code-generator#9659).Includes tests for deprecated argument filtering that I didn't find in GraphQL.js.
Thanks for your review time.