Skip to content

use get() instead of direct dict access#1995

Open
DanielJanicek wants to merge 1 commit intomainfrom
djanicek/safe-vector-check
Open

use get() instead of direct dict access#1995
DanielJanicek wants to merge 1 commit intomainfrom
djanicek/safe-vector-check

Conversation

@DanielJanicek
Copy link
Copy Markdown
Contributor

I'm getting an error while setting up tests to run in parallel: KeyError: 'vectorizerConfig'
Link: https://github.com/weaviate/weaviate-e2e-tests/actions/runs/23514532614/job/68444102333#step:17:1473

I'm going to change the test to use the newer config since something is going wrong there too I think, but this seems like an easy safety fix. A None value should not cause a runtime error, as it is the exact value we are trying to handle here, so this seems like an easy safety fix.

More info about this change: https://www.geeksforgeeks.org/python/choosing-dict-get-over-dict-in-python/

@DanielJanicek DanielJanicek requested a review from tsmith023 March 25, 2026 15:04
Copy link
Copy Markdown

@orca-security-eu orca-security-eu bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed SAST high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants