Merged
Conversation
![orca-security-eu[bot]](https://avatars.githubusercontent.com/in/276244?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Infrastructure as Code |  0  0  0  0 |
View in Orca |
| Passed |
SAST | 0 0 0 0 |
View in Orca |
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
| Passed |
Vulnerabilities | 0 0 0 0 |
View in Orca |
rlmanrique
force-pushed
the
rod/spfresh
branch
from
9d981f0 to
899d0da
Compare
jfrancoa
reviewed
Mar 20, 2026
| hfresh_search_probe: Optional[ | ||
| int | ||
| ] = CreateCollectionDefaults.hfresh_search_probe, | ||
| distance_metric: Optional[str] = CreateCollectionDefaults.distance_metric, |
Collaborator
There was a problem hiding this comment.
I know this is out of topic for this PR...but as we are already adding both parameters distance_metric and rescore_limit we should also pass it to other vector indeces...what do you think? would it be too much effort? I think all of them support these two arguments, it would be just bypassing it (if it's None it will use the default value anyway)
Collaborator
Author
There was a problem hiding this comment.
Good suggestion. Done!
jfrancoa
reviewed
Mar 20, 2026
weaviate_cli/commands/create.py
Outdated
| "--hfresh_replicas", | ||
| default=CreateCollectionDefaults.hfresh_replicas, | ||
| type=int, | ||
| help="hfresh replicas (default: None).", |
Collaborator
There was a problem hiding this comment.
Make a reference to the posting lists, so that users do not think it has anything to do with shard replicas
Collaborator
Author
|
Thanks for the comments. I addressed them all |
jfrancoa
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.