Merged
Conversation
germasch
approved these changes
Mar 5, 2026
Contributor
germasch
left a comment
germasch
left a comment
There was a problem hiding this comment.
Thanks, looks great to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now with minimal changes to enable HIP support from CMake.
I also changed the check for the CXX compiler to be hipcc or hcc. In the amd/rocm case, amdclang++ is also a valid CXX compiler. In general the CMAKE_HIP_COMPILER can be different from the CMAKE_CXX_COMPILER.