This repository was archived by the owner on Aug 12, 2025. It is now read-only.
Add backtrace to error output when RUST_BACKTRACE=1#311
Merged
8 commits merged intomainfrom Sep 6, 2022
Merged
Conversation
added 4 commits
September 5, 2022 13:16
Signed-off-by: Matt Wilkinson <matt@mattwilkinson.dev>
Signed-off-by: Matt Wilkinson <matt@mattwilkinson.dev>
ghost
changed the title
--stack-trace flag using backtrace featurebacktrace to error output when RUST_BACKTRACE=1
added 4 commits
September 5, 2022 22:56
Signed-off-by: Matt Wilkinson <matt@mattwilkinson.dev>
Signed-off-by: Matt Wilkinson <matt@mattwilkinson.dev>
Signed-off-by: Matt Wilkinson <matt@mattwilkinson.dev>
Signed-off-by: Matt Wilkinson <matt@mattwilkinson.dev>
brooksmtownsend
approved these changes
Sep 6, 2022
ghost
marked this pull request as ready for review
ghost
requested review from
autodidaddict and
thomastaylor312
as code owners
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a stack trace to the error output of commands when environment variables
RUST_BACKTRACEorRUST_LIB_BACKTRACEare set to1.This uses the
std::Error::backtracefeature, which is currently unstable, but was stabilized very recently: rust-lang/rust#99573. However this feature is able to be used now by enabling thebacktracefeature of theanyhowcrate.This should improve our ability to debug
washerrors considerably especially when helping others. Can just ask "hey could you run that again withRUST_BACKTRACE=1 (wash command)and send the output"?Signed-off-by: Matt Wilkinson matt@mattwilkinson.dev