Skip to content

fix: prebuild server binary to prevent health check timeouts#2

Merged
muhammad-tahir-nawaz merged 2 commits intomainfrom
fix/prebuild-server-binary
Mar 31, 2026
Merged

fix: prebuild server binary to prevent health check timeouts#2
muhammad-tahir-nawaz merged 2 commits intomainfrom
fix/prebuild-server-binary

Conversation

@muhammad-tahir-nawaz
Copy link
Copy Markdown
Contributor

Summary

  • Splits go run into go build + execute in the integration test workflow
  • go run compiles at runtime (~5 min), racing against the health check's ~5 min exponential backoff timeout
  • Pre-building the binary ensures the server starts instantly, so the health check reliably finds it running

Test plan

  • Run an integration test workflow that uses server_cmd and verify the server starts before the health check begins
  • Confirm health check no longer times out

🤖 Generated with Claude Code

`go run` compiles the Go binary at runtime, which takes ~5 minutes in
CI. The health check starts immediately after and uses exponential
backoff with a ~5 minute total timeout, so it races against compilation
and frequently loses. Splitting into `go build` + execute ensures the
server is running before the health check begins.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown

Trivy Scan Results

Vulnerabilities Found


Report Summary

┌────────┬──────┬─────────────────┬─────────┐
│ Target │ Type │ Vulnerabilities │ Secrets │
├────────┼──────┼─────────────────┼─────────┤
│   -    │  -   │        -        │    -    │
└────────┴──────┴─────────────────┴─────────┘
Legend:
- '-': Not scanned
- '0': Clean (no security findings detected)

… timeouts

With Go 1.26, `go run` compilation takes >5 minutes in CI, exceeding
the health check timeout window (315s). Split into a dedicated build
step followed by running the pre-built binary, so compilation time
is isolated and the server starts instantly before the health check.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown

Trivy Scan Results

Vulnerabilities Found


Report Summary

┌────────┬──────┬─────────────────┬─────────┐
│ Target │ Type │ Vulnerabilities │ Secrets │
├────────┼──────┼─────────────────┼─────────┤
│   -    │  -   │        -        │    -    │
└────────┴──────┴─────────────────┴─────────┘
Legend:
- '-': Not scanned
- '0': Clean (no security findings detected)

@muhammad-tahir-nawaz muhammad-tahir-nawaz merged commit b454602 into main Mar 31, 2026
3 checks passed
@muhammad-tahir-nawaz muhammad-tahir-nawaz deleted the fix/prebuild-server-binary branch March 31, 2026 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant