Fix c23 for dns lib, add function pointers prototypes#264
Open
PPN-SD wants to merge 2 commits intowahern:masterfrom
Open
Fix c23 for dns lib, add function pointers prototypes#264PPN-SD wants to merge 2 commits intowahern:masterfrom
PPN-SD wants to merge 2 commits intowahern:masterfrom
Conversation
…ngs. Signed-off-by: Nicolas PARLANT <nicolas.parlant@parhuet.fr>
4 tasks
>src/signal.c:545:31: error: assignment to ‘__sighandler_t’ {aka ‘void (*)(int)’} from
>incompatible pointer type ‘void (*)(void)’[-Wincompatible-pointer-types]
> 545 | sa.sa_handler = &ls_noop;
> | ^
Signed-off-by: Nicolas PARLANT <nicolas.parlant@parhuet.fr>
Collaborator
|
dns.c is taken from https://github.com/wahern/dns and fixes should go over there first |
Collaborator
|
FYI I cherry picked your signal.c change into master but I had to fix an unused warning that came up when using clang. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pick up from quantcast/qfs@f035a95
Closes: #261