Skip to content

Delimiter 507#509

Merged
spgarbet merged 2 commits intomainfrom
delimiter_507
Mar 19, 2026
Merged

Delimiter 507#509
spgarbet merged 2 commits intomainfrom
delimiter_507

Conversation

@spgarbet
Copy link
Member

Revert a couple instances that are hardcoded to "," in other LOCALES

@spgarbet spgarbet requested a review from jubilee2 March 18, 2026 16:22
@spgarbet
Copy link
Member Author


══ Results ══════════════════════════════════════════════════════════════════════════
Duration: 580.8 s

── Skipped tests (13) ───────────────────────────────────────────────────────────────
• No Data Quality Project provided. Tests Skipped (1):
  test-904-exportDataQuality.R:4:3
• No value provided for EXPORT_REPORTS_ID. Tests Skipped (3):
  test-240-exportTypedReports-Functionality.R:6:5,
  test-240-exportTypedReports-Functionality.R:52:5,
  test-240-exportTypedReports-Functionality.R:70:5
• Tests to be developed for 3.0.0 release (9):
  test-151-exportRecords-ArgumentValidation.R:4:5,
  test-151-exportRecords-Functionality.R:4:5, test-152-exportRecordsWithDags.R:4:5,
  test-153-exportRecordsWithEvents.R:4:5,
  test-155-exportRecordsWithRepeatingInstruments.R:4:5,
  test-180-exportRecordsOffline-ArgumentValidation.R:4:5,
  test-180-exportRecordsOffline-Functionality.R:4:5,
  test-190-exportReports-ArgumentValidation.R:4:5,
  test-190-exportReports-Functionality.R:4:5

[ FAIL 0 | WARN 0 | SKIP 13 | PASS 2074 ]

Copy link
Collaborator

@jubilee2 jubilee2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change makes sense. Using sep = "," for these endpoints is appropriate given REDCap returns logging and metadata exports as comma-separated regardless of locale delimiter settings.

@spgarbet
Copy link
Member Author

CSS was intentional. This is included in metadata showing field renddring directives. It has a ':' as part of the language. It could be escaped as CSV allows for that, but forcing ',' is one strategy to avoid parse errors.

@spgarbet spgarbet merged commit 1154ba9 into main Mar 19, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants