Add support for using a proxy to install Splunk#331
Open
haught wants to merge 3 commits intovoxpupuli:masterfrom
Open
Add support for using a proxy to install Splunk#331haught wants to merge 3 commits intovoxpupuli:masterfrom
haught wants to merge 3 commits intovoxpupuli:masterfrom
Conversation
Member
|
thanks for the PR! Can you add some tests for the changes? |
Author
|
I looked through the tests before I PR'd and really didn't see anything like it that would test for this change. The change doesn't change a config file or anything, it just passes along two variables to puppet-archive. I am not even sure what I would be testing for. |
Member
|
You could test the values of the archive resource attributes given various inputs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This PR adds support to use a given proxy for install the forwarder and enterprise Splunk. It simply passes the options to puppet-archive.
This Pull Request (PR) fixes the following issues