fix: replace bare except with except Exception in useragent.py#7296
Open
harshadkhetpal wants to merge 1 commit intovoxel51:developfrom
Open
fix: replace bare except with except Exception in useragent.py#7296harshadkhetpal wants to merge 1 commit intovoxel51:developfrom
harshadkhetpal wants to merge 1 commit intovoxel51:developfrom
Conversation
Bare `except:` catches all exceptions including SystemExit, KeyboardInterrupt and GeneratorExit. Using `except Exception:` is more precise and follows Python best practices (PEP 8). Fixes #noissue
Collaborator
|
Thanks for opening this pull request, @harshadkhetpal! 🎉 A maintainer will review your changes soon. In the meantime, please ensure:
Helpful resources: |
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughUpdated exception handling in Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Member
|
@harshadkhetpal think you can push changes to all the bare except locations in the source for consistency? I found at least 176 occurrences on the grep -rn "^\s*except\s*:" --include="*.py" fiftyone/All bare exceptions found
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #7296 +/- ##
===========================================
+ Coverage 99.10% 99.25% +0.15%
===========================================
Files 85 101 +16
Lines 23353 29047 +5694
===========================================
+ Hits 23143 28830 +5687
- Misses 210 217 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace bare
except:withexcept Exception:infiftyone/utils/useragent.py.Bare
except:silently catches all exceptions — includingSystemExit,KeyboardInterrupt, andGeneratorExit— which can suppress critical signals and make programs impossible to interrupt.except Exception:is the correct, Pythonic choice when the intent is to swallow non-fatal errors.Change:
Testing
No behavior change — style/correctness fix only. The
passblock continues to swallow non-fatal exceptions while correctly allowingSystemExitandKeyboardInterruptto propagate.Summary by CodeRabbit