Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors various components for improved cleanliness and structure, with an emphasis on enhanced startup configuration and clearer separation between connection server components. The changes include adding environment variable placeholders, updating the echoserver binding with additional logging, and refactoring the connserver module to use a dedicated MasterDuplex interface.
Reviewed Changes
Copilot reviewed 13 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| mount/example.env | Added commented-out environment variable placeholders. |
| examples/echoserver/src/main.rs | Updated binding address to be more permissive and added a startup log. |
| docker-compose.yml | Introduced service definitions for voltlane-connserver and backend-server. |
| connserver/src/master.rs | Added a new MasterDuplex trait and its TcpMasterDuplex implementation. |
| connserver/src/main.rs | Refactored to use the new ConnServer API with master duplex connection. |
| connserver/src/connserver.rs | Updated server implementation to accept a MasterDuplex instance at runtime. |
| connserver/src/connection/{mod.rs, client.rs} | Added modular client handling for improved connection management. |
| connserver/src/config.rs | Introduced fill_from_env for configuration via environment variables. |
| connserver/Cargo.toml | Added dependencies for async-trait and dotenvy. |
| Dockerfile.example_echoserver | Provided build instructions for the sample echoserver. |
| Dockerfile | Provided build instructions for connserver. |
| .dockerignore | Added common patterns to ignore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.