Fix CIF rhombohedral symmetry scoring mutating imported lattice#70
Fix CIF rhombohedral symmetry scoring mutating imported lattice#70clemisch wants to merge 3 commits intovincefn:masterfrom
Conversation
Score alternate CIF space-group settings on a temporary Crystal instead of the live imported object, preventing :R/:H probing from corrupting rhombohedral hexagonal cell metrics during pyobjcryst CIF import. happened with "_symmetry_equiv_pos_as_xyz" keyword in CIFs
|
Thanks for the PR - I'm not sure creating a tmp Could this be done instead by just creating a tmp |
|
Updated the fix to avoid constructing a temporary Crystal during Is that what you meant in your suggestion? One caveat: the candidate-parse path now uses |
|
I think I found the appropriate exception type: |
Score alternate CIF space-group settings on a temporary Crystal instead of the live imported object, preventing :R/:H probing from corrupting rhombohedral hexagonal cell metrics during pyobjcryst CIF import.
See #67